-
Notifications
You must be signed in to change notification settings - Fork 163
GC with Image in unsupported use cases #1979
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
GC with Image in unsupported use cases #1979
Conversation
a3d9ee5
to
84840bc
Compare
Test Results 539 files - 6 539 suites - 6 33m 47s ⏱️ + 8m 14s For more details on these failures, see this check. Results for commit 0e1052e. ± Comparison against base commit dd30aff. This pull request removes 37 tests.
♻️ This comment has been updated with latest results. |
bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/graphics/Image.java
Outdated
Show resolved
Hide resolved
bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/graphics/Image.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think that printing to system out is appropriate here.
Either it is an error, then we should throw an exception or it should simply be ignored.
bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/graphics/Image.java
Outdated
Show resolved
Hide resolved
5deef61
to
6ae9927
Compare
Logging a warning for GC initialized with unsupported use cases. 1. all dynamic images (retrieved via any of the existing providers). 2. all images for which handles in other zoom values have already been created.
6ae9927
to
0e1052e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks now better using the error handler, but I think the message must be enhanced, e.g. it should explain what is the alternative to use instead.
Just a assume a common use-case, where I load an Image from a file, not I want to draw some test/watermark on it and save it again. How is this supposed to work? At best we add a new snippet that shows best practice on how to perform image modifications "the supported way" and then reference it in the message.
Logging a warning for GC initialized with unsupported use cases.
Examples
Run this examples with following VM arguments